Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Pathlib #212

Merged
merged 5 commits into from
Nov 7, 2024
Merged

Support Pathlib #212

merged 5 commits into from
Nov 7, 2024

Conversation

mavaylon1
Copy link
Contributor

@mavaylon1 mavaylon1 commented Aug 20, 2024 •
edited
Loading

Motivation

What was the reasoning behind this change? Please explain the changes briefly.

Fix #181

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.56%. Comparing base (e5c2e9e) to head (ebd5950).

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #212      +/-   ##
==========================================
+ Coverage   85.53%   85.56%   +0.03%     
==========================================
  Files           5        5              
  Lines        1182     1185       +3     
  Branches      291      292       +1     
==========================================
+ Hits         1011     1014       +3     
  Misses        115      115              
  Partials       56       56

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavaylon1
Copy link
Contributor Author

The coverage for the patch is 100%. We are good.

@mavaylon1 mavaylon1 marked this pull request as ready for review August 21, 2024 15:17
@h-mayorquin
Copy link

Great!

stephprince
stephprince previously approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@stephprince stephprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mavaylon1 mavaylon1 merged commit 3f78f9c into dev Nov 7, 2024
24 checks passed
@mavaylon1 mavaylon1 deleted the path branch November 7, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephprince stephprince stephprince approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Support pathlib.Path in ZarrIO
4 participants
@mavaylon1 @codecov-commenter @h-mayorquin @stephprince